Re: [PATCH net-next v2 2/3] dts: mt7988a: Add built-in ethernet phy firmware node

[Krzysztof Kozlowski]

On 19/02/2025 09:39, Sky Huang wrote:
> From: Sky Huang <skylake.huang@xxxxxxxxxxxx>
> 
> Add built-in ethernet phy firmware node in mt7988a.dtsi.
> 
> Signed-off-by: Sky Huang <skylake.huang@xxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 6 ++++++

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters


>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> index 88b56a24efca..f2679702c328 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> @@ -322,6 +322,12 @@ lvts: lvts@1100a000 {
>  			nvmem-cell-names = "lvts-calib-data-1";
>  		};
>  
> +		phyfw: phy-firmware@f000000 {

Not a real device.

> +			compatible = "mediatek,2p5gphy-fw";
> +			reg = <0 0x0f100000 0 0x20000>,

Not tested enough. See SoC maintainer profile for clean DTS.

> +			      <0 0x0f0f0018 0 0x20>;
> +		};

Best regards,
Krzysztof