Re: [PATCH v11 12/23] x86/resctrl: Introduce interface to display number of free counters

From: Dave Martin
Date: Wed Feb 19 2025 - 08:31:29 EST


On Fri, Feb 07, 2025 at 12:59:55PM -0600, Moger, Babu wrote:
> Hi Reinette,
>
> On 2/5/2025 6:19 PM, Reinette Chatre wrote:
> > Hi Babu,
> >
> > On 1/22/25 12:20 PM, Babu Moger wrote:

[...]

> > > diff --git a/Documentation/arch/x86/resctrl.rst b/Documentation/arch/x86/resctrl.rst
> > > index 31ff764deeeb..99cae75559b0 100644
> > > --- a/Documentation/arch/x86/resctrl.rst
> > > +++ b/Documentation/arch/x86/resctrl.rst
> > > @@ -299,6 +299,14 @@ with the following files:
> > > memory bandwidth tracking to a single memory bandwidth event per
> > > monitoring group.
> > > +"available_mbm_cntrs":
> > > + The number of monitoring counters available for assignment in each
> > > + domain when mbm_cntr_assign mode is enabled on the system.
> > > + ::
> > > +
> >
> > Documentation jumps in with some hardcoded values that may cause confusion.
> > It looks to be missing something like (and looking back this also applies
> > to "num_mbm_cntrs"):
> > "For example, on a system with 30 available monitoring/(hardware?) counters in
> > each of its L3 domains:"
>
> Sure.

It could make sense to write something like
"... 30 available [hardware] memory bandwidth counters in each ..."

MPAM has different kinds of counters, at least in theory.

(No big deal, though.)

Cheers
---Dave