Re: [PATCH] ntsync: Set the permissions to be 0666

[Greg Kroah-Hartman]

On Tue, Feb 18, 2025 at 05:57:31PM -0600, Elizabeth Figura wrote:
> On Friday, 14 February 2025 06:28:00 CST Mike Lothian wrote:
> > This allows ntsync to be usuable by non-root processes out of the box
> > 
> > Signed-off-by: Mike Lothian <mike@xxxxxxxxxxxxxx>
> > ---
> >  drivers/misc/ntsync.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/misc/ntsync.c b/drivers/misc/ntsync.c
> > index 055395cde42b..586b86243e1d 100644
> > --- a/drivers/misc/ntsync.c
> > +++ b/drivers/misc/ntsync.c
> > @@ -1208,6 +1208,7 @@ static struct miscdevice ntsync_misc = {
> >  	.minor		= MISC_DYNAMIC_MINOR,
> >  	.name		= NTSYNC_NAME,
> >  	.fops		= &ntsync_fops,
> > +	.mode		= 0666, // Setting file permissions to 0666
> >  };
> >  
> >  module_misc_device(ntsync_misc);
> > 
> 
> Reviewed-by: Elizabeth Figura <zfigura@xxxxxxxxxxxxxxx>
> 
> --
> 
> The comment seems rather redundant, but otherwise this is correct and prudent.

I agree, I'll drop the comment when I apply it, thanks.

greg k-h