Re: [PATCH v8 01/14] rust: time: Add Ktime::from_ns()

[Andreas Hindborg]

"Benno Lossin" <benno.lossin@xxxxxxxxx> writes:

> On 18.02.25 14:27, Andreas Hindborg wrote:
>> From: Lyude Paul <lyude@xxxxxxxxxx>
>>
>> A simple function to turn the provided value in nanoseconds into a Ktime
>> value. We allow any type which implements Into<bindings::ktime_t>, which
>> resolves to Into<i64>.
>>
>> This is useful for some of the older DRM APIs that never got moved to
>> Ktime.
>
> Are these older DRM APIs on the C side, or on the Rust side? If they are
> on the Rust side, we should just move them to Ktime, no?
>
>> Signed-off-by: Lyude Paul <lyude@xxxxxxxxxx>
>> Reviewed-by: Lyude Paul <lyude@xxxxxxxxxx>
>
> This seems wrong considering the `From Lyude Paul` line above :) (or is
> it possible to review your own patch?)
>
> The patch itself looks good, so iff the above question is answered with
> "the older DRM APIs are on the C side" then:
>
> Reviewed-by: Benno Lossin <benno.lossin@xxxxxxxxx>

It occurs to me that I am actually not relying on this patch for this
series any longer, so I will just drop it.


Best regards,
Andreas Hindborg