RE: [EXTERNAL] [PATCH] [net-next v2] octeontx2: hide unused label
From: Suman Ghosh
Date: Wed Feb 19 2025 - 13:01:30 EST
> drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 2 ++
>drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c | 2 ++
> 2 files changed, 4 insertions(+)
>
>diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
>b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
>index c7c562f0f5e5..cfed9ec5b157 100644
>--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
>+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
>@@ -3214,8 +3214,10 @@ static int otx2_probe(struct pci_dev *pdev, const
>struct pci_device_id *id)
>
> return 0;
>
>+#ifdef CONFIG_DCB
> err_free_zc_bmap:
> bitmap_free(pf->af_xdp_zc_qidx);
>+#endif
> err_sriov_cleannup:
> otx2_sriov_vfcfg_cleanup(pf);
> err_pf_sriov_init:
>diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
>b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
>index 63ddd262d122..7ef3ba477d49 100644
>--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
>+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
>@@ -737,8 +737,10 @@ static int otx2vf_probe(struct pci_dev *pdev, const
>struct pci_device_id *id)
>
> return 0;
>
>+#ifdef CONFIG_DCB
> err_free_zc_bmap:
> bitmap_free(vf->af_xdp_zc_qidx);
>+#endif
> err_unreg_devlink:
> otx2_unregister_dl(vf);
> err_shutdown_tc:
>--
>2.39.5
[Suman] Thanks for the patch, looks good to me.
Reviewed-by: Suman Ghosh <sumang@xxxxxxxxxxx>