Re: [PATCH] auxdisplay: MAX6959 should select BITREVERSE

[Andy Shevchenko]

On Wed, Feb 19, 2025 at 7:06 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> If CONFIG_BITREVERSE is not enabled:
>
>     max6959.c:(.text+0x92): undefined reference to `byte_rev_table'

Thanks for the fix patch!

> While at it, sort the existing selects alphabetically

In general it seems okay when headers are all generic, but...

...

>  config MAX6959
>         tristate "Maxim MAX6958/6959 7-segment LED controller"
>         depends on I2C
> -       select REGMAP_I2C
> +       select BITREVERSE
>         select LINEDISP
> +       select REGMAP_I2C

...

In this case I prefer to have them kinda grouped, so generic go first
and the subsystem related follows, something like just putting the
BITREVERSE selection before the REGMAP_I2C. With this you don't even
need to add a paragraph to the commit message.

-- 
With Best Regards,
Andy Shevchenko