Re: [PATCH] pm: cpupower: bench: Prevent NULL dereference on malloc failure

From: Shuah Khan
Date: Wed Feb 19 2025 - 15:51:45 EST


On 2/19/25 05:27, Zhongqiu Han wrote:
If malloc returns NULL due to low memory, 'config' pointer can be NULL.
Add a check to prevent NULL dereference.

Signed-off-by: Zhongqiu Han <quic_zhonhan@xxxxxxxxxxx>
---
tools/power/cpupower/bench/parse.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/tools/power/cpupower/bench/parse.c b/tools/power/cpupower/bench/parse.c
index 080678d9d74e..bd67c758b33a 100644
--- a/tools/power/cpupower/bench/parse.c
+++ b/tools/power/cpupower/bench/parse.c
@@ -121,6 +121,10 @@ FILE *prepare_output(const char *dirname)
struct config *prepare_default_config()
{
struct config *config = malloc(sizeof(struct config));
+ if (!config) {
+ perror("malloc");
+ return NULL;
+ }
dprintf("loading defaults\n");

Thanks. Applied for Linux 6.15-rc1 - will be included in pull request
to PM maintainer.

https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git/log/?h=cpupower

thanks,
-- Shuah