Re: [PATCH v2 2/7] dt-bindings: firmware: Add i.MX95 SCMI LMM and CPU protocol

[Rob Herring]

On Wed, Feb 12, 2025 at 03:40:24PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@xxxxxxx>
> 
> Add i.MX SCMI Extension protocols bindings for:
> - Logic Machine Management(LMM) Protocol
>   intended for boot, shutdown, and reset of other logical machines (LM).
>   It is usually used to allow one LM to manager another used as an offload
>   or accelerator engine..
> - CPU Protocol.
>   allows an agent to start or stop a CPU. It is used to manage auxiliary
>   CPUs in an LM (e.g. additional cores in an AP cluster).
> 
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> ---
>  .../devicetree/bindings/firmware/nxp,imx95-scmi.yaml     | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml b/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml
> index 1a95010a546b14b1d3d97aa990c0305a551f2620..75f63819285b191a815dc4287e34d299983b1c40 100644
> --- a/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml
> +++ b/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml
> @@ -11,6 +11,14 @@ maintainers:
>    - Peng Fan <peng.fan@xxxxxxx>
>  
>  properties:
> +  protocol@80:
> +    $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node'
> +    unevaluatedProperties: false

Please add 'description' to these to say what the protocol is.

> +
> +    properties:
> +      reg:
> +        const: 0x80
> +
>    protocol@81:
>      $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node'
>      unevaluatedProperties: false
> @@ -19,6 +27,14 @@ properties:
>        reg:
>          const: 0x81
>  
> +  protocol@82:
> +    $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node'
> +    unevaluatedProperties: false
> +
> +    properties:
> +      reg:
> +        const: 0x82
> +
>    protocol@84:
>      $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node'
>      unevaluatedProperties: false
> 
> -- 
> 2.37.1
>