Re: [PATCH v6 23/42] x86/resctrl: Add resctrl_arch_ prefix to pseudo lock functions

[Reinette Chatre]

Hi James,

On 2/7/25 10:18 AM, James Morse wrote:
> resctrl's pseudo lock has some copy-to-cache and measurement
> functions that are micro-architecture specific.
> 
> For example, pseudo_lock_fn() is not at all portable.
> 
> Label these 'resctrl_arch_' so they stay under /arch/x86.
> To expose these functions to the filesystem code they need an entry
> in a header file, and can't be marked static.
> 
> Signed-off-by: James Morse <james.morse@xxxxxxx>
> Tested-by: Carl Worth <carl@xxxxxxxxxxxxxxxxxxxxxx> # arm64
> Tested-by: Shaopeng Tan <tan.shaopeng@xxxxxxxxxxxxxx>
> Reviewed-by: Shaopeng Tan <tan.shaopeng@xxxxxxxxxxxxxx>
> Reviewed-by: Tony Luck <tony.luck@xxxxxxxxx>
> ---

...

> -static int measure_l3_residency(void *_plr)
> +int resctrl_arch_measure_l3_residency(void *_plr)
>  {
>  	struct pseudo_lock_region *plr = _plr;
>  	struct residency_counts counts = {0};
> @@ -1205,14 +1207,14 @@ static int pseudo_lock_measure_cycles(struct rdtgroup *rdtgrp, int sel)
>  	plr->cpu = cpu;
>  
>  	if (sel == 1)
> -		thread = kthread_run_on_cpu(measure_cycles_lat_fn, plr,
> -					    cpu, "pseudo_lock_measure/%u");
> +		thread = kthread_run_on_cpu(resctrl_arch_measure_cycles_lat_fn,
> +					     plr, cpu, "pseudo_lock_measure/%u");

checkpatch.pl does not like this extra space that sneaked in.

With spacing fixed:
| Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>

Reinette