Re: [PATCH bpf-next v2 8/9] selftests/bpf: Add selftests for load-acquire and store-release instructions
From: Eduard Zingerman
Date: Wed Feb 19 2025 - 20:22:41 EST
On Thu, 2025-02-20 at 01:08 +0000, Peilin Ye wrote:
[...]
> Then realized that I can't check __clang_major__ in .../prog_tests/*
> files (e.g. I was building prog_tests/verifier.c using GCC). I think
> ideally we should do something similar to prog{,_test}s/arena_atomics.c,
> i.e. use a global bool in BPF source to indicate if we should skip this
> test, but that seems to require non-trivial changes to
> prog_tests/verifier.c?
>
> For the purpose of this patchset, let me keep dummy_test(), like what we
> have now in verifier_ldsx.c.
Well, that's unfortunate.
Thank you for trying.