RE: [PATCH v2 10/16] x86/mce: Separate global and per-CPU quirks

[Zhuo, Qiuxu]

> From: Yazen Ghannam <yazen.ghannam@xxxxxxx>
> [...]
> > Is it better to add the following description here? So that it's clear
> > we don't apply the quirks for older CPUs.
> >
> >     Older CPUs (prior to family 6) can't reach this point and already return
> early
> >     due to the check of __mcheck_cpu_ancient_init().
> >
> 
> I don't know. As you said, the older CPUs don't enter this code, so why refer
> to them at all?
> 

As the following check "if (c->x86_vfm < INTEL_NEHALEM_EP ..." includes older 
CPUs (e.g. family == 5). Stating that older CPUs don't reach this point makes it 
clear that the quirks are not applied to them.

> > > +	 */
> > > +	if (c->x86_vfm < INTEL_NEHALEM_EP &&
> > > this_cpu_read(mce_num_banks))
> > > +		this_cpu_ptr(mce_banks_array)[0].init = false; }
> > > +
> > [...]
> >
> > LGTM. Thanks.
> >
> >     Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@xxxxxxxxx>
> >
> 
> Thanks,
> Yazen