Re: [RESEND PATCH] sctp: Replace zero-length array with flexible array member

From: Kees Cook
Date: Wed Feb 19 2025 - 21:24:53 EST


On Wed, Feb 19, 2025 at 12:26:36PM +0100, Thorsten Blum wrote:
> Replace the deprecated zero-length array with a modern flexible array
> member in the struct sctp_idatahdr.
>
> Link: https://github.com/KSPP/linux/issues/78
> Reviewed-by: Kees Cook <kees@xxxxxxxxxx>
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>

I assume this will be picked up by netdev. I see 2 sctp patches pending
on patchwork:

https://patchwork.kernel.org/project/netdevbpf/list/?series=&submitter=&state=&q=sctp&archive=&delegate=

-Kees

> ---
> include/linux/sctp.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/sctp.h b/include/linux/sctp.h
> index 836a7e200f39..19eaaf3948ed 100644
> --- a/include/linux/sctp.h
> +++ b/include/linux/sctp.h
> @@ -239,7 +239,7 @@ struct sctp_idatahdr {
> __u32 ppid;
> __be32 fsn;
> };
> - __u8 payload[0];
> + __u8 payload[];
> };
>
> struct sctp_idata_chunk {
> --
> 2.48.1
>

--
Kees Cook