Re: [PATCH v6 1/4] PCI: dwc: Add support for vendor specific capability search
From: 'Manivannan Sadhasivam'
Date: Thu Feb 20 2025 - 02:29:12 EST
On Thu, Feb 20, 2025 at 11:44:36AM +0530, Shradha Todi wrote:
>
>
> > -----Original Message-----
> > From: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> > Sent: 18 February 2025 20:11
> > To: Shradha Todi <shradha.t@xxxxxxxxxxx>
> > Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; lpieralisi@xxxxxxxxxx; kw@xxxxxxxxx; robh@xxxxxxxxxx;
> > bhelgaas@xxxxxxxxxx; jingoohan1@xxxxxxxxx; Jonathan.Cameron@xxxxxxxxxx; fan.ni@xxxxxxxxxxx; nifan.cxl@xxxxxxxxx;
> > a.manzanares@xxxxxxxxxxx; pankaj.dubey@xxxxxxxxxxx; cassel@xxxxxxxxxx; 18255117159@xxxxxxx;
> > quic_nitegupt@xxxxxxxxxxx; quic_krichai@xxxxxxxxxxx; gost.dev@xxxxxxxxxxx
> > Subject: Re: [PATCH v6 1/4] PCI: dwc: Add support for vendor specific capability search
> >
> > On Fri, Feb 14, 2025 at 04:20:04PM +0530, Shradha Todi wrote:
> > > Add vendor specific extended configuration space capability search API
> > > using struct dw_pcie pointer for DW controllers.
> > >
> > > Signed-off-by: Shradha Todi <shradha.t@xxxxxxxxxxx>
> >
> > I took this patch and modified to pass the 'struct dwc_pcie_vsec_id' to the API to simplify the callers:
> > https://lore.kernel.org/linux-pci/20250218-pcie-qcom-ptm-v1-2-16d7e480d73e@xxxxxxxxxx
> >
> > - Mani
> >
>
> I saw the series. I'm okay to move that to a common header file to avoid duplication but I feel that this movement will
> cause my patch to become dependent on your PTM series. Since that series in still in v1 stage and mine is already in v6,
> I feel the debugfs patchset will get further delayed. If you are okay, I could take in the changes as part of v7 after waiting
> for some more reviews. Or, the debugfs patches could be reviewed as it is, and the changes or movement could go on top
> of that?
>
You can take my first 2 patches. I'll post my v2 on top of your next version.
- Mani
--
மணிவண்ணன் சதாசிவம்