Re: [PATCH v2 3/3] dt-bindings: hwmon: emc2305: Add YAML binding documentation for emc2305 driver

[Krzysztof Kozlowski]

On 19/02/2025 16:52, Guenter Roeck wrote:
> On 2/19/25 06:01, Krzysztof Kozlowski wrote:
> [ ... ]
> 
>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - hwmon,emc2301
>>> +      - hwmon,emc2302
>>> +      - hwmon,emc2303
>>> +      - hwmon,emc2305
>>
>> Nope.
>>
>> Was it ever internally reviewed?
>>
> No. I intentionally do not review bindings because I notoriously get it wrong,
> and instead rely on DT maintainers.
> 
> I agree though that this one is really bad :-(


Wait, my comment was not towards you, but towards NXP and their internal
review. NXP is a big company, not individual contributor, so they should
use internal review to catch obvious issues instead of using community
resources for such trivial tasks.

Best regards,
Krzysztof