Re: [PATCH] drm/arm/komeda: Add a condition check before removing sysfs attribute

[Maxime Ripard]

On Thu, Feb 20, 2025 at 04:53:58PM +0800, oushixiong1025@xxxxxxx wrote:
> From: Shixiong Ou <oushixiong@xxxxxxxxxx>
> 
> [WHY] If the call to sysfs_create_group() fails, there is
>       no need to call function sysfs_remove_group().
> 
> [HOW] Add a condition check before removing sysfs attribute.
> 
> Signed-off-by: Shixiong Ou <oushixiong@xxxxxxxxxx>

What are you trying to fix exactly? AFAIK, there's no code path that
calls komeda_dev_destroy() after komeda_dev_create() has failed.

Maxime

Attachment: signature.asc
Description: PGP signature