Re: [PATCH 4/5] clk: qcom: videocc: Add support to attach multiple power domains

From: Bryan O'Donoghue
Date: Thu Feb 20 2025 - 05:21:59 EST


On 20/02/2025 07:15, Jagadeesh Kona wrote:
Yes, its logically the same just done in core code.

Yes, this code attaches domains before configuring the PLLs, but it attaches PDs after get_sync()
is called on device. As I mentioned in other patch earlier, if we attach PDS after get_sync() is
already called on device, then power domains are not getting enabled during the probe, leading to
the same improper PLL configuration issue. But the current patch series posted will fix this issue

That's not what I see.

The PLLs start and the GDSCs which depend also start.

Perhaps you could give the code a try and comment ?

---
bod