Re: [PATCH] scripts/checksyscalls.sh: Add usage message, fix -Wno-error
From: Ricardo B. Marlière
Date: Thu Feb 20 2025 - 06:53:55 EST
On Thu Feb 20, 2025 at 7:59 AM -03, ritvikfoss wrote:
> From: Ritvik Gupta <ritvikfoss@xxxxxxxxx>
>
> Currently 'scripts/checksyscalls.sh' does not
> provide guidance when executed without specifying
> a compiler, instead it attempts to execute
> '-Wno-error' parameter as a command,
> resulting in 'Wno-error: Command not found' error.
>
> This patch adds a usage message that is displayed
> when no compiler is provided as parameter to
> improve clarity.
>
> Signed-off-by: Ritvik Gupta <ritvikfoss@xxxxxxxxx>
> ---
> scripts/checksyscalls.sh | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/scripts/checksyscalls.sh b/scripts/checksyscalls.sh
> index 1e5d2eeb726d..14c04227c96e 100755
> --- a/scripts/checksyscalls.sh
> +++ b/scripts/checksyscalls.sh
> @@ -10,6 +10,21 @@
> # checksyscalls.sh gcc gcc-options
> #
>
> +usage() {
> +cat <<EOF
> +Usage: $0 <compiler> [compiler-options]
> +
> +Example:
> + $0 gcc
> +EOF
> +exit 1
> +}
> +
> +if [[ $# -eq 0 ]]; then
[[ is bash, while this script is POSIX #!/bin/sh
> + echo "Error: No compiler provided."
> + usage
> +fi
> +
> ignore_list() {
> cat << EOF
> #include <asm/types.h>