Re: [PATCH v2] auxdisplay: MAX6959 should select BITREVERSE

[Andy Shevchenko]

On Thu, Feb 20, 2025 at 10:07:52AM +0100, Geert Uytterhoeven wrote:
> Hi Andy,
> 
> On Thu, 20 Feb 2025 at 09:21, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
> > On Thu, Feb 20, 2025 at 9:48 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> > >
> > > If CONFIG_BITREVERSE is not enabled:
> > >
> > >     max6959.c:(.text+0x92): undefined reference to `byte_rev_table'
> >
> > LGTM now, thanks.
> > Do you think we are in an emergency to send it for v6.14?
> 
> No.
> 
> > If possible, I would prefer to send this in PR for v6.15 as the
> > problem was from day 1 and only bitbot found the configuration so far
> > that fails to build.
> 
> I had to go through lots of loops to disable BITREVERSE and reproduce
> the build issue (e.g. CRC32 selects BITREVERSE), so I doubt anyone
> will ever encounter it with a real config.

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko