Re: [PATCH 09/18] irqdomain: Rename _add functions to _add_*_of_node

[Thomas Gleixner]

Jiri!

On Thu, Feb 20 2025 at 09:17, Jiri Slaby wrote:
> sorry for the delay, I drowned in tty.

I'm sorry for you :)

> On 06. 02. 25, 17:22, tglx wrote:
>> I'm not convinced that this _of_node() _fwnode() churn is actually
>> valuable. I rather go and consolidate the code so that the core
>> functions take a fwnode argument, i.e.
>> 
>>     - irq_domain_add_xxx(node, ...)
>>     + irq_domain_add_xxx(of_fwnode_handle(node), ....)
>> 
>> It's not asked too much from the developer to use of_fwnode_handle() at
>> the call site and the resulting treewide churn is pretty much the same
>> as in any case all call sites need to be touched.
>
> OK, NP. I am only confused by your "I rather go". Does it mean you are 
> already on it? Or should I translate that as "I'd rather go", ie. /me 
> doing the work -- I expect this case and can indeed do the job. I just 
> don't want to duplicate the work.

I meant to write "I'd" and was obviously expecting you doing this :)

Thanks,

        tglx