Re: [PATCH net-next 2/2] net: axienet: Add support for AXI 2.5G MAC

[Andrew Lunn]

> > Okay, so it's a synthesis option, where that may be one of:
> >
> > 1. SGMII/1000base-X only
> > 2. 2500base-X only
> > 3. dynamically switching between (1) and (2).
> >
> > > We'll use MAC ability register to detect if MAC is configured for
> > > 2.5G. Will it be fine to advertise both 1G and 2.5G in that case?
> >
> > Please document in a comment that the above are synthesis options, and that
> > dynamically changing between them is possible but not implemented by the driver.
> > Note that should anyone use axienet for SFP modules, then (1) is essentially the
> > base functionality, (2) is very limiting, and (3) would be best.
> >
> > Not only will one want to limit the MAC capabilities, but also the supported interface
> > modes. As it's been so long since the patch was posted, I don't remember whether it
> > did that or not.
> >
> 
> Sure, will document in the comment and limit both mac capabilities and supported interfaces accordingly.
> Thank you for your quick response and guidance. I really appreciate your support!

It is likely somebody will want 3 sometime in the future, since the
current limitation is pretty silly. So please think about this, try
not to put in any roadblocks to that extension.

	Andrew