Re: [PATCH liburing v1 0/3] Fix Compilation Error on Android and Some Cleanup

From: Jens Axboe
Date: Thu Feb 20 2025 - 09:51:52 EST



On Thu, 20 Feb 2025 21:34:19 +0700, Ammar Faizi wrote:
> Another day in the thrilling world of cross-platform compatibility...
>
> Alviro discovered that some Android versions are missing `aligned_alloc()`
> in `<stdlib.h>`, leading to a compilation error on Termux 0.118.0:
>
> ```
> cmd-discard.c:383:11: warning: call to undeclared library function \
> 'aligned_alloc' with type 'void *(unsigned long, unsigned long)'; ISO \
> C99 and later do not support implicit function declarations \
> [-Wimplicit-function-declaration]
>
> [...]

Applied, thanks!

[1/3] liburing.h: Remove redundant double negation
commit: 1d11475301931478bb35f2573e1741f5d9088132
[2/3] liburing.h: Explain the history of `io_uring_get_sqe()`
commit: d1c100351ffb3483f5d3fc661b2d41d48062bec1
[3/3] Fix missing `aligned_alloc()` on some Android devices
commit: 5c788d514b9ed6d1a3624150de8aa6db403c1c65

Best regards,
--
Jens Axboe