Re: [PATCH] i2c: core: mark i2c_detect_address noinline_for_stack

[Geert Uytterhoeven]

Hi Sui,

On Mon, 10 Feb 2025 at 09:03, Su Hui <suhui@xxxxxxxxxxxx> wrote:
> When compile with CONFIG_FRAME_WARN=1024, there can be a warning:
>
> drivers/i2c/i2c-core-base.c: In function ‘i2c_detect.isra’:
> drivers/i2c/i2c-core-base.c:2507:1: warning: the frame size of 1028 bytes
> is larger than 1024 bytes [-Wframe-larger-than=].
>  2507 | }
>       | ^
>
> Mark i2c_detect_address() noinline_for_stack to avoid this warning.
>
> Signed-off-by: Su Hui <suhui@xxxxxxxxxxxx>

I have posted an alternative fix:
"[PATCH] i2c: core: Allocate temporary client dynamically"
https://lore.kernel.org/f9aa39362e918b62aec0567f899b37d8d3c44710.1740064176.git.geert+renesas@xxxxxxxxx/

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds