Re: Null-pointer-dereference in ef100_process_design_param()

[Edward Cree]

On 19/02/2025 10:04, Kyungwook Boo wrote:
> It seems that a null pointer dereference issue in ef100_process_design_param()
> can occur due to an uninitialized pointer efx->net_dev.

Yes, your diagnosis looks correct to me.
Moreover, besides the calls you identify, the function also has calls to
 netif_err() using the same efx->net_dev pointer.

My preferred solution is to keep ef100_check_design_params() where it is,
 but move the netif_set_tso_max_{size,segs}() calls into
 ef100_probe_netdev(), after the netdevice is allocated, and using the
 values stashed in nic_data; also to replace the netif_err() calls with
 pci_err().  I will develop a patch accordingly.