Re: [PATCH v2 net 5/9] net: enetc: update UDP checksum when updating originTimestamp field
From: Vladimir Oltean
Date: Thu Feb 20 2025 - 10:53:02 EST
On Wed, Feb 19, 2025 at 01:42:43PM +0800, Wei Fang wrote:
> There is an issue with one-step timestamp based on UDP/IP. The peer will
> discard the sync packet because of the wrong UDP checksum. For ENETC v1,
> the software needs to update the UDP checksum when updating the
> originTimestamp field, so that the hardware can correctly update the UDP
> checksum when updating the correction field. Otherwise, the UDP checksum
> in the sync packet will be wrong.
>
> Fixes: 7294380c5211 ("enetc: support PTP Sync packet one-step timestamping")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Wei Fang <wei.fang@xxxxxxx>
> ---
Reviewed-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
Tested-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
Really good catch!