Re: [PATCH] Alpha: Emulate unaligned LDx_L/STx_C for data consistency
From: Matt Turner
Date: Thu Feb 20 2025 - 11:58:44 EST
On Thu, Feb 20, 2025 at 11:46 AM Matt Turner <mattst88@xxxxxxxxx> wrote:
>
> On Wed, Feb 19, 2025 at 7:46 AM Maciej W. Rozycki <macro@xxxxxxxxxxx> wrote:
> > #define OP_INT_MASK ( 1L << 0x28 | 1L << 0x2c /* ldl stl */ \
> > + | 1L << 0x2a | 1L << 0x2e /* ldl_l stl_c */ \
> > | 1L << 0x29 | 1L << 0x2d /* ldq stq */ \
> > + | 1L << 0x2b | 1L << 0x2f /* ldq_l stq_c */ \
> > | 1L << 0x0c | 1L << 0x0d /* ldwu stw */ \
> > | 1L << 0x0a | 1L << 0x0e ) /* ldbu stb */
> >
> > #define OP_WRITE_MASK ( 1L << 0x26 | 1L << 0x27 /* sts stt */ \
> > | 1L << 0x2c | 1L << 0x2d /* stl stq */ \
> > + | 1L << 0x2e | 1L << 0x2d /* stl_c stq_c */ \
>
> stq_c should be 0x2f, not 0x2d. Looks like a copy-n-paste mistake.
The good news is that OP_WRITE_MASK appears to be unused going all the
way back to the import into git, so this doesn't indicate a problem
with any of the testing that's been done.