Re: [PATCH v2 3/8] PCI: brcmstb: Do not assume that reg field starts at LSB

[Florian Fainelli]

On 2/14/2025 9:39 AM, Jim Quinlan wrote:
> When setting a register field it was assumed that the field started at the
> lsb of the register.  Although the masks do indeed start at the lsb, and
> this will probably not change, it is prudent to use a method that makes no
> assumption about the mask's placement in the register.
>
> The uXXp_replace_bits() calls are used since they are already prevalent
> in this driver.
>
> Signed-off-by: Jim Quinlan <james.quinlan@xxxxxxxxxxxx>

Reviewed-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
--
Florian