RE: [PATCH net-next] net: xilinx: axienet: Implement BQL

[Gupta, Suraj]

[AMD Official Use Only - AMD Internal Distribution Only]

> -----Original Message-----
> From: Sean Anderson <sean.anderson@xxxxxxxxx>
> Sent: Thursday, February 20, 2025 10:29 PM
> To: Gupta, Suraj <Suraj.Gupta2@xxxxxxx>; Pandey, Radhey Shyam
> <radhey.shyam.pandey@xxxxxxx>; netdev@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx; Paolo Abeni <pabeni@xxxxxxxxxx>; David S .
> Miller <davem@xxxxxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Simek, Michal
> <michal.simek@xxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Eric Dumazet
> <edumazet@xxxxxxxxxx>; Andrew Lunn <andrew+netdev@xxxxxxx>
> Subject: Re: [PATCH net-next] net: xilinx: axienet: Implement BQL
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On 2/18/25 11:00, Sean Anderson wrote:
> > On 2/15/25 06:32, Gupta, Suraj wrote:
> >>
> >>
> >>> -----Original Message-----
> >>> From: Sean Anderson <sean.anderson@xxxxxxxxx>
> >>> Sent: Saturday, February 15, 2025 2:43 AM
> >>> To: Pandey, Radhey Shyam <radhey.shyam.pandey@xxxxxxx>;
> >>> netdev@xxxxxxxxxxxxxxx
> >>> Cc: linux-kernel@xxxxxxxxxxxxxxx; Paolo Abeni <pabeni@xxxxxxxxxx>; David S
> .
> >>> Miller <davem@xxxxxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>;
> >>> Simek, Michal <michal.simek@xxxxxxx>;
> >>> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Eric Dumazet
> >>> <edumazet@xxxxxxxxxx>; Andrew Lunn <andrew+netdev@xxxxxxx>; Sean
> >>> Anderson <sean.anderson@xxxxxxxxx>
> >>> Subject: [PATCH net-next] net: xilinx: axienet: Implement BQL
> >>>
> >>> Caution: This message originated from an External Source. Use proper
> >>> caution when opening attachments, clicking links, or responding.
> >>>
> >>>
> >>> Implement byte queue limits to allow queueing disciplines to account
> >>> for packets enqueued in the ring buffers but not yet transmitted.
> >>>
> >>
> >> Could you please check if BQL can be implemented for DMAengine flow?
> >
> > I can have a look, but TBH I do not test the dma engine configuration
> > since it is so much slower.
>
> I had a look, and BQL is already implemented for dmaengine.
>
> --Sean

Ok, great then. Thanks :)