Re: [PATCH RESEND v3 05/17] dt-bindings: iio: adc: ad7768-1: document regulator provider property

From: David Lechner
Date: Thu Feb 20 2025 - 16:22:19 EST


On 2/12/25 12:16 PM, Jonathan Santos wrote:
> The AD7768-1 provides a buffered common-mode voltage output
> on the VCM pin that can be used to bias analog input signals.
>
> Add regulators property to enable the use of the VCM output,
> referenced here as vcm_output, by any other device.
>
> Signed-off-by: Jonathan Santos <Jonathan.Santos@xxxxxxxxxx>
> ---
> v3 Changes:
> * VCM is now provided as a regulator within the device, instead of a
> custom property.
>
> v2 Changes:
> * New patch in v2.
> ---
> .../bindings/iio/adc/adi,ad7768-1.yaml | 21 +++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml
> index e2f9782b5fc8..38f7bb0a0e20 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml
> @@ -59,6 +59,19 @@ properties:
> in any way, for example if the filter decimation rate changes.
> As the line is active low, it should be marked GPIO_ACTIVE_LOW.
>
> + regulators:
> + type: object
> + description:
> + list of regulators provided by this controller.
> +
> + properties:
> + vcm_output:

I think property names are supposed to use - and not _.

+ vcm-output:

> + $ref: /schemas/regulator/regulator.yaml#
> + type: object
> + unevaluatedProperties: false
> +
> + additionalProperties: false
> +
> reset-gpios:
> maxItems: 1
>
> @@ -152,6 +165,14 @@ examples:
> reg = <0>;
> label = "channel_0";
> };
> +
> + regulators {
> + vcm_reg: vcm_output {
> + regulator-name = "vcm_output";
> + regulator-min-microvolt = <900000>;
> + regulator-max-microvolt = <2500000>;
> + };
> + };
> };
> };
> ...