Re: [PATCH] objtool: Add bch2_trans_unlocked_or_in_restart_error() to bcachefs noreturns
From: Josh Poimboeuf
Date: Thu Feb 20 2025 - 17:08:29 EST
On Tue, Feb 18, 2025 at 02:42:30PM +0800, Youling Tang wrote:
> From: Youling Tang <tangyouling@xxxxxxxxxx>
>
> Fix the following objtool warning during build time:
> fs/bcachefs/btree_cache.o: warning: objtool: btree_node_lock.constprop.0() falls through to next function bch2_recalc_btree_reserve()
> fs/bcachefs/btree_update.o: warning: objtool: bch2_trans_update_get_key_cache() falls through to next function need_whiteout_for_snapshot()
>
> bch2_trans_unlocked_or_in_restart_error() is an Obviously Correct (tm)
> panic() wrapper, add it to the list of known noreturns.
>
> Fixes: b318882022a8 ("bcachefs: bch2_trans_verify_not_unlocked_or_in_restart()")
> Reported-by: k2ci<kernel-bot@xxxxxxxxxx>
> Signed-off-by: Youling Tang <tangyouling@xxxxxxxxxx>
Acked-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
Peter, can you take this one?
--
Josh