[PATCH] procfs: use str_yes_no() to remove hardcoded "yes" and "no".
From: Ethan Carter Edwards
Date: Thu Feb 20 2025 - 17:34:13 EST
Remove hard-coded strings by using the str_yes_no() helper function
provided by <linux/string_choices.h>.
Signed-off-by: Ethan Carter Edwards <ethan@xxxxxxxxxxxxxxxxx>
---
fs/proc/base.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/proc/base.c b/fs/proc/base.c
index cd89e956c322440f35ed75187416f4b247b07f96..f28acc5d5ec8b1248dfb95cf4e2e50fcb83a5ebf 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -60,6 +60,7 @@
#include <linux/file.h>
#include <linux/generic-radix-tree.h>
#include <linux/string.h>
+#include <linux/string_choices.h>
#include <linux/seq_file.h>
#include <linux/namei.h>
#include <linux/mnt_namespace.h>
@@ -3280,14 +3281,14 @@ static int proc_pid_ksm_stat(struct seq_file *m, struct pid_namespace *ns,
seq_printf(m, "ksm_merging_pages %lu\n", mm->ksm_merging_pages);
seq_printf(m, "ksm_process_profit %ld\n", ksm_process_profit(mm));
seq_printf(m, "ksm_merge_any: %s\n",
- test_bit(MMF_VM_MERGE_ANY, &mm->flags) ? "yes" : "no");
+ str_yes_no(test_bit(MMF_VM_MERGE_ANY, &mm->flags)));
ret = mmap_read_lock_killable(mm);
if (ret) {
mmput(mm);
return ret;
}
seq_printf(m, "ksm_mergeable: %s\n",
- ksm_process_mergeable(mm) ? "yes" : "no");
+ str_yes_no(ksm_process_mergeable(mm)));
mmap_read_unlock(mm);
mmput(mm);
}
---
base-commit: 27eddbf3449026a73d6ed52d55b192bfcf526a03
change-id: 20250220-proc_yes_or_no-8c4575ab76ec
Best regards,
--
Ethan Carter Edwards <ethan@xxxxxxxxxxxxxxxxx>