Re: [PATCH RESEND v3 13/17] iio: adc: ad7768-1: add multiple scan types to support 16-bits mode

From: David Lechner
Date: Thu Feb 20 2025 - 17:38:46 EST


On 2/12/25 12:18 PM, Jonathan Santos wrote:
> When the device is configured to Sinc5 filter and decimation x8,
> output data is reduced to 16-bits in order to support 1 MHz of
> sampling frequency due to clock limitation.

It would be a bit more clear if this said that x8 is only possible
with sinc5, so we don't have to check the filter type in the code.
At first, I thought the code was missing that part of the check.

>
> Use multiple scan types feature to enable the driver to switch
> scan type in runtime, making possible to support both 24-bit and
> 16-bit resolution.
>
> Signed-off-by: Jonathan Santos <Jonathan.Santos@xxxxxxxxxx>
> ---

Reviewed-by: David Lechner <dlechner@xxxxxxxxxxx>