Re: [PATCH v2 net-next 2/6] net: hibmcge: Add rx checksum offload supported in this module
From: Jakub Kicinski
Date: Thu Feb 20 2025 - 18:12:04 EST
On Tue, 18 Feb 2025 16:58:25 +0800 Jijie Shao wrote:
> +static netdev_features_t hbg_net_fix_features(struct net_device *netdev,
> + netdev_features_t features)
> +{
> + return features & HBG_SUPPORT_FEATURES;
> +}
Do you need this? Why would the stack try to set features you don't
support/advertize? Also you may clear SW features unnecessarily this
way.
--
pw-bot: cr