Re: [PATCH v12 04/16] x86/mm: get INVLPGB count max from CPUID
From: Borislav Petkov
Date: Thu Feb 20 2025 - 20:58:43 EST
On Thu, Feb 20, 2025 at 07:53:03PM -0500, Rik van Riel wrote:
> diff --git a/arch/x86/Kconfig.cpu b/arch/x86/Kconfig.cpu
> index 2a7279d80460..bb6943c21b7f 100644
> --- a/arch/x86/Kconfig.cpu
> +++ b/arch/x86/Kconfig.cpu
> @@ -401,6 +401,10 @@ menuconfig PROCESSOR_SELECT
> This lets you choose what x86 vendor support code your kernel
> will include.
>
> +config X86_BROADCAST_TLB_FLUSH
> + def_bool y
> + depends on CPU_SUP_AMD && 64BIT
> +
> config CPU_SUP_INTEL
> default y
> bool "Support Intel processors" if PROCESSOR_SELECT
> @@ -431,6 +435,7 @@ config CPU_SUP_CYRIX_32
> config CPU_SUP_AMD
> default y
> bool "Support AMD processors" if PROCESSOR_SELECT
> + select X86_BROADCAST_TLB_FLUSH
> help
> This enables detection, tunings and quirks for AMD processors
You missed my comment again. How about you read review feedback more carefully
please?
CPU_SUP_AMD selects X86_BROADCAST_TLB_FLUSH which depends on CPU_SUP_AMD which
selects X86_BROADCAST_TLB_FLUSH which depends on CPU_SUP_AMD...
You need to make up your mind in which way the dependency should be. Certainly
not circular.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette