Re: [PATCH] selftests: sched: add sched as a default selftest target

[Shan]

On 21-02-2025 11:30 am, Chris Hyser wrote:
> From: Chris Hyser <chris.hyser@xxxxxxxxxx>
> Sent: Thursday, February 20, 2025 11:21 PM
> To: Sinadin Shan; Shrikanth Hegde
> Cc: linux-kselftest@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; shuah@xxxxxxxxxx
> Subject: Re: [PATCH] selftests: sched: add sched as a default selftest target
> > From: Sinadin Shan <sinadin.shan@xxxxxxxxxx>
> > Sent: Thursday, February 20, 2025 11:23 AM
> > To: Chris Hyser; Shrikanth Hegde
> > Cc: linux-kselftest@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; shuah@xxxxxxxxxx
> > Subject: Re: [PATCH] selftests: sched: add sched as a default selftest target
> >
> > > > I guess my question is what if SCHED_CORE was supposed to be configed into
> > > > the test kernel?  Silently burying the error might be bad. I'm not strongly tied to
> > > > that, just looking for opinions. At the same time, if you put the orig change in,
> > > > people w/o SCHED_CORE on will start seeing "failures" they didn't see before,
> > > > yes? and that seems bad.
> > >
> > > Yes, that seems bad as rightly pointed out by Shrikant. I have a patch
> > > that does the above mentioned skip, and if skipping is a right option to
> > > take here I can send it in the next version.
> >
> > If that is the plan, I prefer to fix it myself.
>
> Ok. Here is a better plan. I suspected there must be some convention for all
> these tests (that you are obviously familiar with), I just feel bad for how this test
> originally got jammed in here. If you already have a patch, we should just go with
> that and yes adding that code seems like the exact right thing to do.

Thanks Chris, I shall send the new patch.

-Shan

> -chrish