Re: [PATCH v4 1/4] dt-bindings: clock: qcom: Add compatible for QCM6490 boards

[Taniya Das]

On 2/21/2025 2:50 PM, Krzysztof Kozlowski wrote:
> On Thu, Feb 20, 2025 at 09:52:50AM +0530, Taniya Das wrote:
>> Add the new QCM6490 compatible to support the reset functionality for
>> Low Power Audio subsystem.
>>
>> Signed-off-by: Taniya Das <quic_tdas@xxxxxxxxxxx>
>> ---
>>  Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml
>> index 488d63959424088ede67835eb4dcf3feef6d0848..64efb2c533d1e71a9bdc3bf0d245b00cec00841a 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml
>> @@ -20,6 +20,7 @@ description: |
>>  properties:
>>    compatible:
>>      enum:
>> +      - qcom,qcm6490-lpassaudiocc
>>        - qcom,sc7280-lpassaoncc
>>        - qcom,sc7280-lpassaudiocc
>>        - qcom,sc7280-lpasscorecc
>> @@ -68,7 +69,9 @@ allOf:
>>        properties:
>>          compatible:
>>            contains:
>> -            const: qcom,sc7280-lpassaudiocc
>> +            enum:
>> +              - qcom,sc7280-lpassaudiocc
>> +              - qcom,qcm6490-lpassaudiocc
> 
> Alphabetical order... although now I question whether these are
> compatible. Nothing in commit msg explains this, but it should.
> 

Sure, I will add the details of why we need this in the commit.

> Best regards,
> Krzysztof
>