Re: [PATCH] crypto: inside-secure: eip93: Correctly handle return of for sg_nents_for_len

From: Herbert Xu
Date: Fri Feb 21 2025 - 04:26:29 EST


On Sun, Feb 16, 2025 at 12:36:18AM +0100, Christian Marangi wrote:
> Fix smatch warning for sg_nents_for_len return value in Inside Secure
> EIP93 driver.
>
> The return value of sg_nents_for_len was assigned to an u32 and the
> error was ignored and converted to a positive integer.
>
> Rework the code to correctly handle the error from sg_nents_for_len to
> mute smatch warning.
>
> Fixes: 9739f5f93b78 ("crypto: eip93 - Add Inside Secure SafeXcel EIP-93 crypto engine support")
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
> ---
> .../crypto/inside-secure/eip93/eip93-common.c | 25 ++++++++++++++-----
> 1 file changed, 19 insertions(+), 6 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt