Re: [PATCH v3 3/4] kernel: globalize lookup_or_create_module_kobject()

[Rasmus Villemoes]

On Thu, Feb 13 2025, Petr Pavlu <petr.pavlu@xxxxxxxx> wrote:

> On 2/11/25 22:48, Shyam Saini wrote:
>> lookup_or_create_module_kobject() is marked as static and __init,
>> to make it global drop static keyword.
>> Since this function can be called from non-init code, use __modinit
>> instead of __init, __modinit marker will make it __init if
>> CONFIG_MODULES is not defined.
>
> Hm, we should later clean up kernel/params.c to use __init_or_module
> from include/linux/module.h instead of its own __modinit implementation.

Good catch, yes. Mind sending the patch?

Rasmus