Re: [PATCH v2] riscv: KVM: Remove unnecessary vcpu kick
From: Radim Krčmář
Date: Fri Feb 21 2025 - 06:21:28 EST
2025-02-21T18:45:38+08:00, BillXiang <xiangwencheng@xxxxxxxxxxxxxxxxxxx>:
> Remove the unnecessary kick to the vCPU after writing to the vs_file
> of IMSIC in kvm_riscv_vcpu_aia_imsic_inject.
>
> For vCPUs that are running, writing to the vs_file directly forwards
> the interrupt as an MSI to them and does not need an extra kick.
>
> For vCPUs that are descheduled after emulating WFI, KVM will enable
> the guest external interrupt for that vCPU in
> kvm_riscv_aia_wakeon_hgei. This means that writing to the vs_file
> will cause a guest external interrupt, which will cause KVM to wake
> up the vCPU in hgei_interrupt to handle the interrupt properly.
>
> Signed-off-by: BillXiang <xiangwencheng@xxxxxxxxxxxxxxxxxxx>
> ---
> v2: Revise the commit message to ensure it meets the required
> standards for acceptance
Nice, thanks.
Reviewed-by: Radim Krčmář <rkrcmar@xxxxxxxxxxxxxxxx>