Re: [PATCH] ACPI: NUMA: Move get_numa_distances_cnt() helper to needed location

From: Mike Rapoport
Date: Fri Feb 21 2025 - 07:45:37 EST


Hi,

On Thu, Feb 20, 2025 at 02:25:33PM +0800, WangYuli wrote:
> Hi Mike,
>
> On 2025/2/20 14:10, Mike Rapoport wrote:
> > There's no need for relocation, just drop the unused function.
>
> Okay.
>
> But  please take a look at line 295 of the original srat.c. Should the type
> of variable 'd' there be changed to u64, as mentioned in the commit message?

int is enough for more than 2 million nodes, I don't see a problem with it

> If yes, I can quickly put up another commit just to tweak this one place.
>
> Thanks,
>
> --
> WangYuli






--
Sincerely yours,
Mike.