[tip: x86/mm] x86/mm: Replace open-coded gap bounding with clamp()

From: tip-bot2 for Qasim Ijaz
Date: Fri Feb 21 2025 - 09:49:17 EST


The following commit has been merged into the x86/mm branch of tip:

Commit-ID: 282f395244df3663dc24e97a86087431c9192513
Gitweb: https://git.kernel.org/tip/282f395244df3663dc24e97a86087431c9192513
Author: Qasim Ijaz <qasdev00@xxxxxxxxx>
AuthorDate: Sat, 15 Feb 2025 12:52:49
Committer: Ingo Molnar <mingo@xxxxxxxxxx>
CommitterDate: Fri, 21 Feb 2025 15:33:57 +01:00

x86/mm: Replace open-coded gap bounding with clamp()

Rather than manually bounding gap between gap_min and gap_max,
use the well-known clamp() macro to make the code easier to read.

Signed-off-by: Qasim Ijaz <qasdev00@xxxxxxxxx>
Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
Link: https://lore.kernel.org/r/20250215125249.10729-1-qasdev00@xxxxxxxxx
---
arch/x86/mm/mmap.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/arch/x86/mm/mmap.c b/arch/x86/mm/mmap.c
index b8a6fff..5ed2109 100644
--- a/arch/x86/mm/mmap.c
+++ b/arch/x86/mm/mmap.c
@@ -84,7 +84,6 @@ static unsigned long mmap_base(unsigned long rnd, unsigned long task_size,
{
unsigned long gap = rlim_stack->rlim_cur;
unsigned long pad = stack_maxrandom_size(task_size) + stack_guard_gap;
- unsigned long gap_min, gap_max;

/* Values close to RLIM_INFINITY can overflow. */
if (gap + pad > gap)
@@ -94,13 +93,7 @@ static unsigned long mmap_base(unsigned long rnd, unsigned long task_size,
* Top of mmap area (just below the process stack).
* Leave an at least ~128 MB hole with possible stack randomization.
*/
- gap_min = SIZE_128M;
- gap_max = (task_size / 6) * 5;
-
- if (gap < gap_min)
- gap = gap_min;
- else if (gap > gap_max)
- gap = gap_max;
+ gap = clamp(gap, SIZE_128M, (task_size / 6) * 5);

return PAGE_ALIGN(task_size - gap - rnd);
}