Re: [PATCH v3 1/3] drm/format-helper: Add conversion from XRGB8888 to BGR888

From: andriy.shevchenko@xxxxxxxxxxxxxxx
Date: Fri Feb 21 2025 - 10:56:13 EST


On Fri, Feb 21, 2025 at 11:36:00AM +0000, Aditya Garg wrote:
> From: Kerem Karabay <kekrby@xxxxxxxxx>
>
> Add XRGB8888 emulation helper for devices that only support BGR888.

...

> + for (x = 0; x < pixels; x++) {
> + pix = le32_to_cpu(sbuf32[x]);
> + /* write red-green-blue to output in little endianness */
> + *dbuf8++ = (pix & 0x00ff0000) >> 16;
> + *dbuf8++ = (pix & 0x0000ff00) >> 8;
> + *dbuf8++ = (pix & 0x000000ff) >> 0;

put_unaligned_be24()

> + }

...

> + static const u8 dst_pixsize[DRM_FORMAT_MAX_PLANES] = {
> + 3,
> + };

One line?

static const u8 dst_pixsize[DRM_FORMAT_MAX_PLANES] = { 3 };

--
With Best Regards,
Andy Shevchenko