Re: [PATCH v5 -next 04/11] PCI: brcmstb: Reuse config structure
From: Krzysztof Wilczyński
Date: Fri Feb 21 2025 - 11:51:03 EST
Hello,
> > Sorry for the late notice but I get a compilation error on this commit:
> >
> > drivers/pci/controller/pcie-brcmstb.c: In function 'brcm_pcie_turn_off':
> > drivers/pci/controller/pcie-brcmstb.c:1492:14: error: 'struct
> > brcm_pcie' has no member named 'bridge_sw_init_set'; did you mean
> > 'bridge_reset'?
> > ret = pcie->bridge_sw_init_set(pcie, 1);
> > ^~~~~~~~~~~~~~~~~~
> > bridge_reset
> > make[5]: *** [scripts/Makefile.build:194:
> > drivers/pci/controller/pcie-brcmstb.o] Error 1
> >
> > It appears to be fixed with the subsequent commit "PCI: brcmstb: Add
> > bcm2712 support".
> >
> > Can you please look into this and see if you get the same results?
>
> Ah, it is my fault. Thanks for spotting this. This must have happened
> when moving this patch earlier in the series.
No worries. Things happen. We can fix everything. :)
> Krzystof,
>
> I could send a new version of the series or the other option could be to
> rework those two patches in controller/brcmstb?
Happy to modify things on the branch directly. But if it's easier to send
a new version, then feel free. Either approach would work. :)
> I will post later the fixes here if you choose the second option.
Thank you, sir, for a prompt reply! Appreciated.
Krzysztof