Re: [PATCH v1] selftests/user_events: Fix failures caused by test code

[Steven Rostedt]

On Fri, 21 Feb 2025 08:46:31 -0700
Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> wrote:

> On 2/20/25 20:35, realxxyq@xxxxxxx wrote:
> > From: Yiqian Xun <xunyiqian@xxxxxxxxxx>
> > 
> > In parse_abi function,the dyn_test fails because the
> > enable_file isn’t closed after successfully registering an event.
> > By adding wait_for_delete(), the dyn_test now passes as expected.
> > 
> > Signed-off-by: Yiqian Xun <xunyiqian@xxxxxxxxxx>
> > ---
> >   tools/testing/selftests/user_events/dyn_test.c | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/tools/testing/selftests/user_events/dyn_test.c b/tools/testing/selftests/user_events/dyn_test.c
> > index bdf9ab127488..54c9412f8dee 100644
> > --- a/tools/testing/selftests/user_events/dyn_test.c
> > +++ b/tools/testing/selftests/user_events/dyn_test.c
> > @@ -127,6 +127,8 @@ static int parse_abi(int *check, const char *value)
> >   
> >   	close(fd);
> >   
> > +	wait_for_delete();
> > +
> >   	return ret;
> >   }
> >     
> 
> Adding Steve for review.
> 
> Steve, please review the patch. If you are happy with it
> give me Ack or Reviewed-by if you want to take this through
> my tree.

Actually, Beau should review it.

Beau?

Here's the patch: https://lore.kernel.org/all/20250221033555.326716-1-realxxyq@xxxxxxx/

-- Steve