Re: [PATCH 1/2] sched/fair: Do not let idle entities preempt others

[Josh Don]

On Fri, Feb 21, 2025 at 3:12 AM Abel Wu <wuyun.abel@xxxxxxxxxxxxx> wrote:
>
> A task with SCHED_IDLE policy doesn't preempt others by definition, and
> the semantics are intended to be preserved when extending to cgroups
> introduced in commit 304000390f88 ("sched: Cgroup SCHED_IDLE support").
>
> But current implementation allows idle entities to preempt each other
> on wakeup, which seems not behave as expected especially after
> commit faa42d29419d ("sched/fair: Make SCHED_IDLE entity be preempted in strict hierarchy")
> so fix this by explicitly skip wakeup preemption for idle entities.

Thanks, looks good to me.

Reviewed-by: Josh Don <joshdon@xxxxxxxxxx>