Re: [PATCH v3 1/3] drm/format-helper: Add conversion from XRGB8888 to BGR888

[andriy.shevchenko@xxxxxxxxxxxxxxx]

On Fri, Feb 21, 2025 at 05:21:08PM +0000, Aditya Garg wrote:
> > On 21 Feb 2025, at 9:21 PM, andriy.shevchenko@xxxxxxxxxxxxxxx wrote:
> > On Fri, Feb 21, 2025 at 11:36:00AM +0000, Aditya Garg wrote:

...

> >> + for (x = 0; x < pixels; x++) {
> >> + pix = le32_to_cpu(sbuf32[x]);
> >> + /* write red-green-blue to output in little endianness */
> >> + *dbuf8++ = (pix & 0x00ff0000) >> 16;
> >> + *dbuf8++ = (pix & 0x0000ff00) >> 8;
> >> + *dbuf8++ = (pix & 0x000000ff) >> 0;
> > 
> > put_unaligned_be24()

(1)

> >> + }

...

> >> + static const u8 dst_pixsize[DRM_FORMAT_MAX_PLANES] = {
> >> + 3,
> >> + };
> > 
> > One line?
> > 
> > static const u8 dst_pixsize[DRM_FORMAT_MAX_PLANES] = { 3 };
> 
> Wrt all the above respective changes, the formatting has been done exactly like what other emulation helps do in the upstream patch.
> 
> I doubt Thomas would want these changes to be done, or would want these changes to be done for the upstream emulation helpers as well.
> 
> For reference: https://github.com/torvalds/linux/blob/master/drivers/gpu/drm/drm_format_helper.c

I'm not sure how this is applicable to (1) above. Otherwise it's fine if there
is a documented style or due to consistency with the existing style.

-- 
With Best Regards,
Andy Shevchenko