Re: [PATCH v2 1/6] dt-bindings: pinctrl: Add bindings for BCM21664 pin controller

[Artur Weber]

On 21.02.2025 21:32, Artur Weber wrote:
> Add device tree bindings for the pin controller included in the
> BCM21664 chip. The bindings are based off brcm,bcm11351-pinctrl.yaml;
> both chips use the same driver, but have different pins, and the
> BCM21664 has 6 alt modes instead of 4.
>
> Signed-off-by: Artur Weber <aweber.kernel@xxxxxxxxx>
> ---
> (...)
> +examples:
> +  - |
> +    pinctrl@35004800 {
> +      compatible = "brcm,bcm21664-pinctrl";
> +      reg = <0x35004800 0x7f0>;
> +
> +      dev-a-active-pins {
> +        /* group node defining 1 standard pin */
> +        std-grp0 {
> +          pins = "gpio00";
> +          function = "alt1";
> +          input-schmitt-enable;
> +          bias-disable;
> +          slew-rate = <1>;
> +          drive-strength = <4>;
> +        };
> +
> +        /* group node defining 2 I2C pins */
> +        i2c-grp0 {
> +          pins = "bsc1clk", "bsc1dat";
> +          function = "alt2";
> +          bias-pull-up = <720>;
> +          input-enable;

bias-pull-up should not have a value (pull up strength is not
supported). Will fix this in the next version.

> +        };
> +      };
> +    };
> +...

Best regards
Artur