[PATCH net-next v6 3/8] net: pktgen: remove some superfluous variable initializing

From: Peter Seiderer
Date: Fri Feb 21 2025 - 16:53:07 EST


Remove some superfluous variable initializing before hex32_arg call (as the
same init is done here already).

Signed-off-by: Peter Seiderer <ps.report@xxxxxxx>
Reviewed-by: Simon Horman <horms@xxxxxxxxxx>
---
Changes v5 -> v6
- adjust to dropped patch ''net: pktgen: use defines for the various
dec/hex number parsing digits lengths'

Changes v4 -> v5
- split up patchset into part i/ii (suggested by Simon Horman)
- add rev-by Simon Horman

Changes v3 -> v4
- new patch (factored out of patch 'net: pktgen: fix access outside of user
given buffer in pktgen_if_write()')
---
net/core/pktgen.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index b97a94cb85ac..204f93de03aa 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -1787,7 +1787,7 @@ static ssize_t pktgen_if_write(struct file *file,
}

if (!strcmp(name, "tos")) {
- __u32 tmp_value = 0;
+ __u32 tmp_value;
len = hex32_arg(&user_buffer[i], 2, &tmp_value);
if (len < 0)
return len;
@@ -1803,7 +1803,7 @@ static ssize_t pktgen_if_write(struct file *file,
}

if (!strcmp(name, "traffic_class")) {
- __u32 tmp_value = 0;
+ __u32 tmp_value;
len = hex32_arg(&user_buffer[i], 2, &tmp_value);
if (len < 0)
return len;
--
2.48.1