Re: [PATCH] rust: workqueue: define built-in bh queues
From: Jarkko Sakkinen
Date: Fri Feb 21 2025 - 23:17:53 EST
On Fri, Feb 21, 2025 at 11:45:38PM +0100, Miguel Ojeda wrote:
> On Fri, Feb 21, 2025 at 11:36 PM Hamza Mahfooz
> <hamzamahfooz@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > We provide these methods because it lets us access these queues from
> > Rust without using unsafe code.
> >
> > Signed-off-by: Hamza Mahfooz <hamzamahfooz@xxxxxxxxxxxxxxxxxxx>
>
> Cc'ing WORKQUEUE -- thanks!
Not meaning to complain but it by practical has no commit message.
Does not meet any quality standards in that area tbh. In order to
make Rust more appealing you really should pay more attention to
this.
I learned absolutely nothing from this.
>
> Cheers,
> Miguel
>
BR, Jarkko