Re: [PATCH 1/6] Change inode_operations.mkdir to return struct dentry *

From: Al Viro
Date: Fri Feb 21 2025 - 23:57:03 EST


On Fri, Feb 21, 2025 at 10:36:30AM +1100, NeilBrown wrote:

> Not all filesystems reliably result in a positive hashed dentry:
>
> - NFS, cifs, hostfs will sometimes need to perform a lookup of
> the name to get inode information. Races could result in this
> returning something different. Note that this lookup is
> non-atomic which is what we are trying to avoid. Placing the
> lookup in filesystem code means it only happens when the filesystem
> has no other option.

At least in case of cifs I don't see that lookup anywhere in your
series. Have I missed it, or...?