Re: [PATCH 05/12] badblocks: return error if any badblock set fails

From: Coly Li
Date: Sat Feb 22 2025 - 01:16:40 EST


On Sat, Feb 22, 2025 at 09:12:53AM +0800, Yu Kuai wrote:
> Hi,
>
> 在 2025/02/21 18:12, Coly Li 写道:
> > So we don’t need to add a negative return value for partial success/failure?
> >
> > Coly Li.
>
> Yes, I think so. No one really use this value, and patch 10 clean this
> up by changing return type to bool.

OK, then it is fine to me.

It will be good to add a code comment that parital setting will be treated as failure.

Thanks.


--
Coly Li